incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC4
Date Thu, 01 Jun 2017 00:33:09 GMT
Hi,

Sorry but it’s -1 binding as the source release contains compiled code. [1]

I checked:
- name contains incubating 
- DISCLAIMER exists
- LICENSE is OK (some minor issues)
- NOTICE is good
- source contains compiled code [1]
- a source file is missing an ASF header [7] There a few other xml and css file that could
also have headers added.
- unable compile from source

Some other minor (IMO non blocking) issues:
- For license you may want to add OCMock (Apache license)
- These two files seem to have double headers [2][3] I assume the Alibaba one can be removed?
- Copyright (c) 2014-present, Facebook, Inc. All rights reserved.” from LICENSE does't match
what is in the files copyright Facebook.
- LICENSE contains incorrect boilerplate text (copyright line)
- May be missing BSD license SocketRocket [4][5][6]?

I think the README may require a bit more instructions on how to compile as it looks like
a few environment variable need to be set up. (i.e ANDROID_HOME) before the scripts are run.

Thanks,
Justin

1. ./apache-weex-incubating-0.12.0-RC4-src/ios/sdk/WeexSDKTests/dependency/libOCMock.a
2. ./apache-weex-incubating-0.12.0-RC4-src/ios/sdk/WeexSDK/Sources/Component/WXLoadingComponent.m
3. ./apache-weex-incubating-0.12.0-RC4-src/ios/sdk/WeexSDK/Sources/Module/WXNavigatorModule.m
4. ./apache-weex-incubating-0.12.0-RC4-src/ios/sdk/WeexSDK/dependency/SRWebSocket.h
5. ./apache-weex-incubating-0.12.0-RC4-src/ios/sdk/WeexSDK/dependency/SRWebSocket.m
6. https://github.com/facebook/SocketRocket/blob/master/LICENSE
7. ./apache-weex-incubating-0.12.0-RC4-src/android/sdk/src/main/java/org/apache/weex/ui/view/listview/ExtendedStaggeredGridLayoutManager.java


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message