incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release: Apache Eagle 0.4.0-incubating
Date Fri, 15 Jul 2016 23:03:23 GMT
Hi,

+1 (binding)

I checked:
- artefact name contains incubating
- hashes and signature good
- DISCLAIMER exits
- LICENSE and NOTICE good
- Most source file have apache headers
- No unexpected binaries in source release
- Can compile from source

Minor issue you (IMO) should fix in the next release:
- there a number of python script without Apache headers

Very minor things you may or may not want to fix in the next release:
- wrong copyright year (2015) in [1]
- year range may be wrong in LICENSE "Copyright (c) 2010-2016 Benjamin Peterson”, looks
to be 2014 to me?
- how is this patch [2] licensed?

Thanks,
Justin

1. mkdocs.yml
2. eagle-external/eagle-ambari/lib/EAGLE/package/patches/add-eagle-quicklink.patch
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message