Hi,
+1 binding
I checked:
- name continues incubating
- good signature and hashes
- LICENSE is missing a couple of things (see below)
- NOTICE is possibly missing NOTICE file from quokka? [2][3]
- Source files have ASF header
- No unexpected binary files in release
- No need to compile
LICENSE is missing:
- normalise CSS - contained within [1]
- glyphicons halflings font [4]
Looks like the the source bundles may be missing jQuery? It’s mentioned in license and needed
by bootstrap but I don't see it bundled.
Very minor things:
- remove the first line of the LICENSE file
Thanks,
Justin
1 ./site/css/bootstrap.min.css
2../site/js/quokka.js
3. https://github.com/Humbedooh/quokka.js/blob/master/NOTICE
4. ./site/fonts/glyphicons-halflings-regular.svg
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
|