incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M2
Date Wed, 20 Apr 2016 02:14:07 GMT
Hi,

+1 binding

I checked:
- incubating in name
- signatures correct
- DISCLAIMER exits
- source LICENSE has some minor issues (see below)
- source NOICE is good
- several JS files are missing Apache headers
- no unexpected binary files in source release
- can compile from source

Source license minor issues:
- MIT licensed [1], note that this file also contains MIT licensed MooTools framework
- This file [3] is under MX4J license, I think this should be mentioned in LICENSE and also
NOTICE as it’s similar to Apache's 1.1 license.
- The Droid fonts [5] are Apache licensed, but it’s not obvious as they are binary files,
so may be good to mention that in LICENSE.

For the binary as above and:
- binary NOTICE some text can be removed (e.g. for the spring projects if you read what you’ve
included they tell what text should be included)
- binary NOTICE no need to mention the name and copyright of the most of the bundled Apache
projects
- didn’t check full contents but brief heck showed no issues.

Other minor things:
-  A number of ASF licensed files are copyright "Clearspring Technologies, Inc.” (for example)
[2] should they be copyright ASF?
- This file still has a Pivotal copyright and patent notice [4]
- The year is incorrect in a number of NOTICE files having "Copyright (c) 2002-2015 Pivotal,
Inc.” or "Copyright (c) [2012-2014] Pivotal Software, Inc.”

Thanks,
Justin

1. ./geode-pulse/src/main/webapp/scripts/lib/jit.js
2. ./geode-core/src/main/java/com/gemstone/gemfire/internal/hll/Bits.java
3. ./geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/MX4JModelMBean.java
4 ./geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/RemoteCQTransactionDUnitTest.java
5. ./geode-pulse/src/main/webapp/css/fonts/DroidSans-Bold-webfont.* and DroidSans-webfont.*


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message