incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M1
Date Wed, 03 Feb 2016 06:06:54 GMT
Hi,

+0.5 for the license issues and unable to compile. Willing to change to +1 if these are sorted
in the next release/explained.

I checked:
- file name contain incubating
- signatures and hashes good
- DISCLAIMER exists
- NOTICE looks OK
- LICENSE is missing a few items (see below). Everything listed in bundled.
- All source files have Apache headers (that need it)
- No unexpected binary in the source release
- I think COMPILING.txt needs some updating and current gradle fails with an error (see below)

License is missing:
- ANSIBuffer (BSD) [1]
- font awesome (front are SIL and css is MIT) [2]
- normalise.css (MIT) [3]
- bootstrap (MIT) [3]
- boot flat (MIT) [4]
- headjs (MIT) [5]
- iCheck (MIT) [6]
- html5shiv (MIT) [7]
- respond (MIT) [8]
- polyfill (MIT/BSD) [8]
- InternalDataSerializer.java [9] contains code from BSD license protobuf that should be in
license

Compile fails with:
Could not GET 'https://plugins.gradle.org/m2/com/github/zafarkhaja/java-semver/0.9.0/java-semver-0.9.0.pom'.
Received status code 502 from server: Bad Gateway

It is unclear how [10] was original licensed has an apache header been put on this file by
mistake? It contains:
//  Created by Eric Zoerner on 2/13/08.
//  Copyright 2008 __MyCompanyName__. All rights reserved.

Do you have permission to use this file [11] which contains ("All Rights Reserved" generally
implies no).
Copyright (C) GemStone Systems, Inc. 2000-2004. All Rights Reserved.

This file [12] incorrectly has an Apache header and is licensed under an MX4J license [13].
While is permissive, it’s not "Apache like" as claimed. The is not list as a category A
license [14] so you probably need to raise a legal JIRA to get it added. It looks to me like
it requires attribution and would need to be listed in LICENSE.

Many java files under [15] contain double headers is this correct? 

Also this file [16] has a double header but this file [17] only has one header with the same
(non Apache) copyright owner and an non standard Apache header. This may need to be mentioned
in NOTICE? [18]

BTW the footer [19] conatins the wrong copyright year.

Several items in LICENSE refer to the generic BSD/MIT license, wouldn’t it be more useful
to point to the actual software license in question?

I didn't look at the binary release and there may be a couple of things I’ve missed from
a quick review.

Thanks,
Justin

1. ./gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/jline/ANSIBuffer.java
2. ./gemfire-site/website/content/font/*
3. ./gemfire-site/website/content/bootstrap/bootstrap.min.css
4. ./gemfire-site/website/content/css/bootflat*
5. ./gemfire-site/website/content/js/head.js
6. ./gemfire-site/website/content/js/jquery.icheck.js
7. ./gemfire-site/website/content/js/html5shiv.js
8. ./gemfire-site/website/content/js/respond.min.js
9 ./gemfire-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java
10. ./gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/ResultsBagJUnitTest.java
11. ./gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/QueryFromClauseCanonicalizationJUnitTest.java
12. ./gemfire-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/MX4JModelMBean.java
13. http://mx4j.sourceforge.net/docs/ch01s06.html
14. http://www.apache.org/legal/resolved.html#category-a
15. ./gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/*.java
16. ./gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexSet.java
17. ./gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/IdentityArrayList.java
18. http://www.apache.org/dev/licensing-howto.html#mod-notice
19. ./gemfire-site/website/layouts/footer.html


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message