incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ralph Goers <>
Subject Re: RTC vs CTR (was: Concerning Sentry...)
Date Thu, 19 Nov 2015 16:16:08 GMT
None of your statements below are any different between RTC or CTR. The only time it makes
aa difference is if no one does reviews.  My feeling is that a community that insists on RTC
believes that code will not be reviewed unless committers are forced to do it.

All I can say, is that for me personally I have found the process of having to create a patch,
submit a code review, wait for the review and participate in it, then wait for the commit
to be onerous enough that I just don’t bother.  As I said, in a CTR community there are
many times where branches are created and the code is reviewed there before being merged because
the authors believe the code is significant enough to require it.  The author is then the
one who merges the branch once the reviews are complete.  To be perfectly honest, this pretty
much exactly matches the way software is created in the development team I work with in the
$day$ job too.


> On Nov 18, 2015, at 12:22 AM, Todd Lipcon <> wrote:
> I gave the logical and valid reasoning in previous posts in this thread:
> 1) no matter how seasoned a committer you are, you might make mistakes
> which are easily caught in code review
> 2) no matter how good you are at coding, your code might not make sense to
> a second pair of eyes, who can ask you to improve comments or docs
> 3) no matter if your code is perfect, the act of another person reading
> your code builds shared ownership over the code, thus alleviating
> bus-factor issues and improving the general feeling of a cohesive community
> developing a single project instead of a loose coalition of people with
> their own fiefdoms.
> I believe this to be generally accepted in the software engineering
> community. I don't know practices at every company, but I know at least
> that most of the well-regarded technology companies I've met with have some
> form of pre-commit review, and certainly many highly adopted open source
> projects as well (especially in infrastructure software).
> Either a high percentage of the world does this for "no logical or valid
> reason" or this is just a matter of opinion, and like I said, we can agree
> to disagree.
> -Todd

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message