incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <justinmcl...@me.com>
Subject Re: [VOTE] Release Apache Myriad 0.1.0 (incubating)
Date Thu, 19 Nov 2015 00:55:20 GMT
Hi,

Sorry but it -1 due to inclusion of a jar in the source release. This issue has come up before
on the incubator mailing list e.g. [4].

Other than some minor license issues everything else is good.

I checked:
- artefact name contains incubating
- signatures and hashes good
- DISCLAIMER exists
- LICENSE has a couple of minor issues
- NOTICE good
- unexpected binary file in the source release [3]
- all source code has Apache headers
- Can build from source

For the LICENSE:
- The appendix part of the LICENSE isn’t correct (i.e. the Apache licence can apply to non
ASF licensed software). Best to use the stock one and not modify it [1]
- LICENSE mentions sub components but there are none listed
- LICENSE is missing normalise.css which is MIT licensed see [2]

You may want to consider:
- Signing with an apache.org email address
- Adding some build instruction to README

Thanks,
Justin

1. http://www.apache.org/licenses/LICENSE-2.0.txt
2. ./myriad-scheduler/src/main/resources/webapp/css/bootstrap-myriad.css
3../gradle/wrapper/gradle-wrapper.jar
4. http://apache.markmail.org/thread/stygi2hnnovbmf46
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message