incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache Brooklyn 0.8.0-incubating [rc2]
Date Fri, 11 Sep 2015 23:49:50 GMT
Hi,

+1 binding

For the source release I checked:
- release files contain incubating
- signatures and hashes correct
- DISCLAIMER exists
- LICENSE has some issues (see below)
- NOTICE is OK	
- No unexpected binary files
- Source files have headers (a few test resources / sample files including java files don’t
however)

Some issues:
- The LICENSE files is structured a little strangely you might want to make it more like other
projects.
- In r.js [2] there a number of copyright owners/licenses (most look to BSD licenses) that
are missing from LICENSE. e.g. uglifyjs, parsejs and base64 code.
- LICENSE is missing sections for dataTables.extensions.js [2], jquery.slideto.min.js [3],
jquery.wiggle.min.js [4] and possible text.js [5].

Thanks,
Justin

1. ./usage/jsgui/src/build/requirejs-maven-plugin/r.js
2. ./usage/jsgui/src/main/webapp/assets/js/libs/dataTables.extensions.js
3. ./apache-brooklyn-0.8.0-incubating-src/usage/jsgui/src/main/webapp/assets/js/libs/jquery.slideto.min.js
4. ./usage/jsgui/src/main/webapp/assets/js/libs/jquery.wiggle.min.js
5. ./usage/jsgui/src/main/webapp/assets/js/libs/text.js
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message