incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abraham Elmahrek <...@cloudera.com>
Subject Re: [VOTE] Release Apache htrace-3.2.0-incubating
Date Sun, 10 May 2015 23:53:56 GMT
Hey Justin,

Thanks for taking the time to review the RC.

Good eyes on the LICENSE and NOTICE files. Some notes there:

   - "Backbone.*" is bundled in marionette
   - The other dependencies that might not need to be listed probably don't
   since I think we simply download them:
   https://github.com/apache/incubator-htrace/blob/master/htrace-core/src/go/Godeps/Godeps.json
   .

I think the issue is that leveldb-devel isn't installed on your machine.
Looking at
https://github.com/apache/incubator-htrace/blob/master/BUILDING.txt, it
seems like we forgot to move the dependency list to htrace-htraced from
htrace-core (
https://github.com/apache/incubator-htrace/blob/master/htrace-core/src/go/BUILDING.txt).
Would this be something we could fix in a follow up release?

-Abe

On Sun, May 10, 2015 at 5:00 AM, Justin Mclean <justin@classsoftware.com>
wrote:

> Hi,
>
> +0 (binding) due to compile issue. Happy to change to +1 if that's
> resolved/explained.
>
> The LICENSE and NOTICE issues can be fixed next release IMO.
>
> I checked:
> - hashes and signatures good
> - artefact name includes incubating
> - DISCLAIMER exits
> - Some minor LICENSE and NOTICE issues (see below)
> - No unexpected binaries in release
> - All source has Apache headers
> - Error compiling from source
>
> NOTICE has several minor issues:
> - Text is wrong as is states "software developed by The Apache Software
> Foundation” when it should say "software developed at
> The Apache Software Foundation”. Note “by” vs “at”.
> - NOTICE is missing copyright year
> - No need to include Apache licensed software in NOTICE (unless it has a
> NOTICE file) [1]
> - Probably no need to add public domain software in NOTICE, but it can go
> in LICENSE like other permissive licenses. [2]
>
> The LICENSE may have several items that don’t need to be in there, only
> bundled software needs to be in the license. [3]
> From a quick look I’m not sure that Levigo, Kingpin, Units, Gorilla mux,
> Backbone.Wreqr or Backbone.Babysitter are bundled.
>
> Looks like LICENSE is missing normalize.css (v2.1.0 | MIT License at
> git.io/normalize).
>
> Also good to place the RC in the correct location [4] and not on
> people.apache.org.
>
> I’m currently getting the compile failing - with this error:
> main:
>      [exec] godep restore...
>      [exec] fatal: Not a git repository (or any of the parent
> directories): .git
>      [exec] github.com/jmhodges/levigo
>      [exec] # github.com/jmhodges/levigo
>      [exec] src/github.com/jmhodges/levigo/batch.go:4:11: fatal error:
> 'leveldb/c.h' file not found
>      [exec]  #include "leveldb/c.h"
>      [exec]           ^
>      [exec] 1 error generated.
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache HTrace ..................................... SUCCESS [
> 1.577 s]
> [INFO] htrace-c .......................................... SUCCESS [
> 0.456 s]
> [INFO] htrace-core ....................................... SUCCESS [
> 12.161 s]
> [INFO] htrace-zipkin ..................................... SUCCESS [
> 5.404 s]
> [INFO] htrace-hbase ...................................... SUCCESS [
> 30.739 s]
> [INFO] htrace-flume ...................................... SUCCESS [
> 19.688 s]
> [INFO] htrace-htraced .................................... FAILURE [
> 2.290 s]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
>
> Any idea what may be causing the compile error?
>
> Thanks,
> Justin
>
> 1. http://www.apache.org/dev/licensing-howto.html#alv2-dep
> 2.
> http://www.apache.org/legal/resolved.html#can-works-placed-in-the-public-domain-be-included-in-apache-products
> 3. http://www.apache.org/dev/licensing-howto.html#guiding-principle
> 4.
> http://incubator.apache.org/guides/releasemanagement.html#glossary-incubator-dist
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message