incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stian Soiland-Reyes <st...@apache.org>
Subject Re: [VOTE] Release Apache Usergrid 1.0.1 (incubating) RC5
Date Fri, 16 Jan 2015 14:56:49 GMT
0 from me (non-binding)


+0 because:
- wrong commit id in vote email
- *.md5 not in regular md5sum format

Verified:
- GPG signature / KEYS
- MD5 (manually, see below).
- SHA
- dist matches git (but wrong commit id in vote)
- cd stack ; mvn clean install -DskipTests=true
- Apache file headers
- Licenses

(Not a blocker) Could you use a regular md5sum file?

    stain@biggie-utopic:~/src/incubator-usergrid$ cat
apache-usergrid-1.0.1-rc5-incubating.tar.gz.md5
apache-usergrid-1.0.1-rc5-incubating.tar.gz:
    43 64 45 6F 9F 1A DA 9C  DA 52 89 67 10 27 9B 7F

    stain@biggie-utopic:~/src/incubator-usergrid$ md5sum -c
apache-usergrid-1.0.1-rc5-incubating.tar.gz.md5
md5sum: apache-usergrid-1.0.1-rc5-incubating.tar.gz.md5: no properly
formatted MD5 checksum lines found

A regular file would look like the output of md5:

    stain@biggie-utopic:~/src/incubator-usergrid$ md5sum
apache-usergrid-1.0.1-rc5-incubating.tar.gz
    4364456f9f1ada9cda52896710279b7f
apache-usergrid-1.0.1-rc5-incubating.tar.gz

    stain@biggie-utopic:~/src/incubator-usergrid$ md5sum
apache-usergrid-1.0.1-rc5-incubating.tar.gz >
apache-usergrid-1.0.1-rc5-incubating.tar.gz.md5

    stain@biggie-utopic:~/src/incubator-usergrid$ md5sum -c
apache-usergrid-1.0.1-rc5-incubating.tar.gz.md5
    apache-usergrid-1.0.1-rc5-incubating.tar.gz: OK


(FYI - The second .sha hash, which you didn't link to, works fine with shasum -c
https://dist.apache.org/repos/dist/dev/incubator/usergrid/1.0.1-rc5/apache-usergrid-1.0.1-rc5-incubating.tar.gz.sha
)


(Not a blocker - as difference is minimal this time)

https://git-wip-us.apache.org/repos/asf?p=incubator-usergrid.git&hb=1.0.1-rc5

does not match

> The current Git commit ID is 867c6dd6f229f929f4528aa5677ee346a70f620d

which is diverged from the branch 1.0.1-rc5 at
6148e4e6186e67cae53bd874bdc6f9470351faab

I don't know which of these we are voting over - presumably it should
rather be the second one?


    stain@biggie-utopic:~/src/incubator-usergrid$ git show 1.0.1-rc5
    commit 6148e4e6186e67cae53bd874bdc6f9470351faab
    Author: Dave Johnson <snoopdave@apache.org>
    Date:   Thu Jan 8 21:21:33 2015 -0500

       Updating .usergridversion to 1.0.1-rc5.

6148e4.. matches the tar.gz content.

To be fair, the difference is minimal and probably not important:

stain@biggie-utopic:~/src/incubator-usergrid$ git diff
867c6dd6f229f929f4528aa5677ee346a70f620d
6148e4e6186e67cae53bd874bdc6f9470351faab
diff --git a/.usergridversion b/.usergridversion
index 276823b..132493d 100644
--- a/.usergridversion
+++ b/.usergridversion
@@ -1 +1 @@
-1.0.2-SNAPSHOT
+1.0.1-rc5




(Not a blocker) Is this license kosher with Apache? (log from
license-maven-plugin)

 (Apple License) AppleJavaExtensions
(com.apple:AppleJavaExtensions:1.4 -
http://developer.apple.com/library/mac/#samplecode/AppleJavaExtensions/Introduction/Intro.html)

https://developer.apple.com/legacy/library/samplecode/AppleJavaExtensions/Listings/README_txt.html#//apple_ref/doc/uid/DTS10000677-README_txt-DontLinkElementID_4

Might need to go into NOTICE if you later do a binary release (but OK
as your vote is only a source code release).






Not a blocker (as your readme says to use -DskipTests=true) :

With Open JDK8 build fails for "mvn clean install":

Tests in error:
  HectorLockManagerIT.org.apache.usergrid.locking.cassandra.HectorLockManagerIT
» Runtime
  SchedulerRuntime2IT>AbstractSchedulerRuntimeIT.setup:54 » Runtime
org.springfr...
  SchedulerRuntime4IT>AbstractSchedulerRuntimeIT.setup:54 » Runtime
org.springfr...
  SchedulerRuntimeIntervalIT>AbstractSchedulerRuntimeIT.setup:54 »
Runtime org.s...
  SchedulerRuntime7IT>AbstractSchedulerRuntimeIT.setup:54 » Runtime
org.springfr...
  SchedulerRuntime5IT>AbstractSchedulerRuntimeIT.setup:54 » Runtime
org.springfr...
  SchedulerRuntime6IT>AbstractSchedulerRuntimeIT.setup:54 » Runtime
org.springfr...
  SchedulerRuntime3IT>AbstractSchedulerRuntimeIT.setup:54 » Runtime
org.springfr...
  SchedulerRuntime1IT>AbstractSchedulerRuntimeIT.setup:54 » Runtime
org.springfr...
  CountingMutatorIT.org.apache.usergrid.persistence.CountingMutatorIT
» Runtime ...
  ConcurrentCoreITSuite.org.apache.usergrid.ConcurrentCoreITSuite » BeanCreation
  ConcurrentCoreIteratorITSuite.org.apache.usergrid.ConcurrentCoreIteratorITSuite
» BeanCreation

On 16 January 2015 at 13:16, Dave <snoopdave@gmail.com> wrote:
> +1 (binding)
>
> On Mon, Jan 12, 2015 at 8:02 PM, John D. Ament <johndament@apache.org>
> wrote:
>
>> +1 binding (from dev @ list)
>>
>> On Mon Jan 12 2015 at 3:09:10 PM Dave <snoopdave@gmail.com> wrote:
>>
>> > The Apache Usergrid PPMC has address the issues found in our earlier
>> > release candidate and has voted to release Apache Usergrid 1.0.1 based on
>> > RC5.
>> >
>> > Here is the vote thread:
>> > https://mail-archives.apache.org/mod_mbox/incubator-
>> > usergrid-dev/201501.mbox/%3CCAF1aazDWk_MgBaYKL4RR55TTbabdxt_
>> > 3FhfEKAAYfLGqKAQFKw%40mail.gmail.com%3E
>> >
>> > Below is the release info and links to the RC5 release files.
>> >
>> > Thanks,
>> > Dave
>> >
>> >
>> > All,
>> >
>> > I propose that we accept the following release candidate as the
>> > official Apache Usergrid 1.0.1 release.
>> >
>> > Usergrid 1.0.1-rc5 includes the following:
>> > ---
>> > The CHANGELOG for the release is available
>> > at:https://git-wip-us.apache.org/repos/asf?p=incubator-
>> > usergrid.git&f=CHANGELOG&hb=1.0.1-rc5
>> >
>> > The branch used to create the release candidate
>> > is:https://git-wip-us.apache.org/repos/asf?p=incubator-
>> > usergrid.git&hb=1.0.1-rc5
>> >
>> > The current Git commit ID is 867c6dd6f229f929f4528aa5677ee346a70f620d
>> >
>> > The release candidate is available
>> > at:https://dist.apache.org/repos/dist/dev/incubator/
>> > usergrid/1.0.1-rc5/apache-usergrid-1.0.1-rc5-incubating.tar.gz
>> >
>> > The MD5 checksum of the release candidate can be found
>> > at:https://dist.apache.org/repos/dist/dev/incubator/
>> > usergrid/1.0.1-rc5/apache-usergrid-1.0.1-rc5-incubating.tar.gz.md5
>> >
>> > The signature of the release candidate can be found
>> > at:https://dist.apache.org/repos/dist/dev/incubator/
>> > usergrid/1.0.1-rc5/apache-usergrid-1.0.1-rc5-incubating.tar.gz.asc
>> >
>> > The GPG key used to sign the release are available
>> > at:https://dist.apache.org/repos/dist/dev/incubator/usergrid/KEYS
>> >
>> > Please download, verify, and test.
>> >
>> > The vote will close on Sun Jan 11 21:22:33 EST 2015
>> >
>> > [ ] +1 Release this as Apache Usergrid 1.0.1
>> > [ ] +0
>> > [ ] -1 Do not release this as Apache Usergrid 1.0.1 because...
>> >
>>



-- 
Stian Soiland-Reyes
Apache Taverna (incubating)
http://orcid.org/0000-0001-9842-9718

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message