incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache Streams 0.1-incubating
Date Sat, 27 Dec 2014 02:58:10 GMT
Hi,

-1 (binding) due to binary files in source release.

./runner/bundles/org.apache.felix.gogo.command_0.12.0.jar
./runner/bundles/org.apache.felix.gogo.runtime_0.10.0.jar
./runner/bundles/org.apache.felix.gogo.shell_0.10.0.jar
./runner/bundles/org.apache.felix.main_4.0.3.jar

But everything else looks good:
- hashes and MD5 fine
- DISCLAIMER exists
- artefact has incubating in file name
- LICENSE and NOTICE good
- No other binary files in source release
- All source code has correct headers
- Can compile from source

I do get some tests failing but that may be due to my environment.

Things you might way to change for next release:
- Update year in NOTICE file
- Add "apache" to the artefact name
- Have both a tar.gz and .zip source release

Thanks,
Justin
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message