incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1
Date Tue, 25 Mar 2014 23:21:37 GMT
Hi,

There are several files missing license headers - is this a concern?
  ./dev/phoenix.importorder
  ./examples/STOCK_SYMBOL.csv
  ./examples/WEB_STAT.csv
  ./examples/pig/test.pig
  ./examples/pig/testdata
  ./phoenix-core/src/main/resources/java.sql.Driver

(ignoring CHANGES and rat.txt files)

Some very minor issues that you may want to fix/change:
- build.txt has "copyright 2010" in it
- build.text should probably be called BUILDING
- there's no .zip package - not require but convenient for users
- source package name doesn't include "apache", not required you may want to consider adding
this for trademark protection

Thanks,
Justin

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message