On Thu, May 05, 2011 at 12:57:03PM -0400, Karl Wright wrote:
> Just to be clear, the ManifoldCF podling needs incubator consideration
> of the release candidate in order to do the release, and three binding
> +1 votes. Any chance that this might happen?
Since I'm only a podling committer and not an Incubator PMC member, I can't
offer a binding vote. Nevertheless, I've performed some superficial QC on the
release candidate.
* All signatures and sums check out, including for the binary artifacts.
* "ant test" succeeds on the expanded src.tar.gz tarball on my OS X laptop.
* The HTTPD extension builds after a Makefile hack (explained below).
* "ant clean" properly cleans up after "ant test".
* There's a problem with line endings in the src.tar.gz archive.
The HTTPD module, mod_authz_annotate, built successfully, but only after I
hacked the Makefile to use "apxs" instead of "apxs2". Not a blocker, IMO, but
now you know. :) Also, neither "make clean" nor "ant clean" cleans up all
build detritus -- these got left behind:
mod_authz_annotate.la
mod_authz_annotate.lo
mod_authz_annotate.o
mod_authz_annotate.slo
I was surprised to find that most of the text files in the src.tar.gz have
Windows line endings. That's ugly, but not a blocker IMO. It looks like they
have the proper settings in Subversion -- e.g. for README.txt, svn:eol-style
is "native" -- so it seems the problem arose because the tar.gz package was
prepared on a Windows box. Maybe try preparing the tar.gz on something
unixish in the future.
Lastly, I ran "ant rat-sources", and though it declared "BUILD SUCCESSFUL",
RAT flagged 8 files:
connectors/filesystem/test-output-postgresql/logging.ini
connectors/filesystem/test-output-postgresql/manifoldcf.log
connectors/filesystem/test-output-postgresql/properties.xml
framework/test-output-postgresql/logging.ini
framework/test-output-postgresql/manifoldcf.log
framework/test-output-postgresql/properties.xml
site/src/documentation/skins/common/xslt/html/split.xsl
site/src/documentation/skins/lucene/note.txt
I'd suggest presenting a clean RAT report next time you call a vote on an RC to
make things easier on everybody.
Hope this helps,
Marvin Humphrey
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
|