From common-issues-return-29482-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org Fri Apr 6 12:43:52 2012 Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D98529E9F for ; Fri, 6 Apr 2012 12:43:51 +0000 (UTC) Received: (qmail 76182 invoked by uid 500); 6 Apr 2012 12:43:51 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 76149 invoked by uid 500); 6 Apr 2012 12:43:51 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 76140 invoked by uid 99); 6 Apr 2012 12:43:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2012 12:43:51 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2012 12:43:46 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 58ED035CEB7 for ; Fri, 6 Apr 2012 12:43:26 +0000 (UTC) Date: Fri, 6 Apr 2012 12:43:26 +0000 (UTC) From: "Hudson (Commented) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1788895439.23013.1333716206366.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-6963) Fix FileUtil.getDU. It should not include the size of the directory or follow symbolic links MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248274#comment-13248274 ] Hudson commented on HADOOP-6963: -------------------------------- Integrated in Hadoop-Hdfs-0.23-Build #219 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/219/]) HADOOP-6963. In FileUtil.getDU(..), neither include the size of directories nor follow symbolic links. (Ravi Prakash via bobby) (Revision 1310018) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310018 Files : * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/pom.xml * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java > Fix FileUtil.getDU. It should not include the size of the directory or follow symbolic links > -------------------------------------------------------------------------------------------- > > Key: HADOOP-6963 > URL: https://issues.apache.org/jira/browse/HADOOP-6963 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Affects Versions: 0.20.205.0, 0.23.1 > Reporter: Owen O'Malley > Assignee: Ravi Prakash > Priority: Critical > Fix For: 1.0.3, 0.23.3 > > Attachments: HADOOP-6963.branch-1.0.2.patch, HADOOP-6963.branch-1.0.2.patch, HADOOP-6963.branch-1.patch, HADOOP-6963.branch-23.patch, HADOOP-6963.branch-23.patch, HADOOP-6963.branch-23.patch > > > The getDU method should not include the size of the directory. The Java interface says that the value is undefined and in Linux/Sun it gets the 4096 for the inode. Clearly this isn't useful. > It also recursively calls itself. In case the directory has a symbolic link forming a cycle, getDU keeps spinning in the cycle. In our case, we saw this in the org.apache.hadoop.mapred.JobLocalizer.downloadPrivateCacheObjects call. This prevented other tasks on the same node from committing, causing the TT to become effectively useless (because the JT thinks it already has enough tasks running) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira