community-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <>
Subject [jira] [Commented] (COMDEV-203) Timezone issues with release dates
Date Thu, 08 Sep 2016 22:31:23 GMT


Sebb commented on COMDEV-203:

Fixed JIRA dates.
This also means that local testing will work even if the timezone is not UTC.

COMDEV-203 Timezone issues with release dates
Fix JIRA dates to always use UTC.


> Timezone issues with release dates
> ----------------------------------
>                 Key: COMDEV-203
>                 URL:
>             Project: Community Development
>          Issue Type: Bug
>          Components: Reporter Tool
>            Reporter: Sebb
> Release dates are stored as seconds since the epoch in the data/release/committe.json
files. In theory all the dates should convert to midnight UTC on the release date.
> If dates are obtained from JIRA, they are converted using the Python method 
> time.mktime() which uses the local timezone. This is done on the reporter.a.o host, which
is currently running UTC. However the host was originally set up in a different timezone,
so some of the dates don't convert to midnight. It should have used calendar.gmtime() instead.
> If the dates are obtained from the user, then the YYYY-MM-DD string is converted using
Javascript using (new Date(yyyy,mm,dd)).getTime() which assumes the local timezone. The converted
value is passed back as an integer to the python script. It should use Date.UTC(yyyy,mm,dd)
instead. Or it could pass back the date string for conversion by the Python code.
> It's easy enough to fix new dates going forward.
> However there are existing dates that will need correction.
> The dates are all converted assuming a local time of midnight, so when they are converted
back again, the local time offset will show up as a number of hours since midnight. This can
be used to adjust the value.

This message was sent by Atlassian JIRA

View raw message