community-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <>
Subject [jira] [Created] (COMDEV-167) regex for committer groups also matches -pmc groups
Date Mon, 28 Sep 2015 21:43:05 GMT
Sebb created COMDEV-167:

             Summary: regex for committer groups also matches -pmc groups
                 Key: COMDEV-167
             Project: Community Development
          Issue Type: Bug
          Components: Reporter Tool
            Reporter: Sebb
            Priority: Minor

The regex for selecting committer (non-pmc) lists does not work.

The regex is currently:


This is applied to data of the form


However the greedy match at the start of the RE allows it to grab everything up to the trailing
single-quote; this is not followed by -pmc so the negative look-ahead has no effect.

The effect of this is that the -pmc groups are stored in the projects.json file.
AFAICT these are not used elsewhere; they just increase the filesize that needs to be downloaded
by the Javascript in the browsers.


It's quite tricky using lookahead with wildcards.

Rather than parse the group list twice, it might be simpler to parse it once and extract all
the groups; the code can the check if the group name ends with -pmc and act accordingly.

This message was sent by Atlassian JIRA

View raw message