community-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé Boutemy (JIRA) <j...@apache.org>
Subject [jira] [Commented] (COMDEV-132) Update to current Datatables release?
Date Fri, 26 Jun 2015 05:18:04 GMT

    [ https://issues.apache.org/jira/browse/COMDEV-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602414#comment-14602414
] 

Hervé Boutemy commented on COMDEV-132:
--------------------------------------

I've no deep experience with JavaScript, but I think that currently the projects-new code
made it simple, with old-school practice of copying js file with renaming and so on

what you seem to expect is to have real dependency management on libraries, minification,
and so on: if we go on this direction, we should switch to JavaScript building tools that
were made for the, ie grunt and al (as no real experience, I can never remember tool names
and usage, but you get the idea)

> Update to current Datatables release?
> -------------------------------------
>
>                 Key: COMDEV-132
>                 URL: https://issues.apache.org/jira/browse/COMDEV-132
>             Project: Community Development
>          Issue Type: Improvement
>          Components: Projects New
>            Reporter: Sebb
>
> The current release of Datatables is 1.10.7; the code currently seems to be using 1.10.4.
> I suggest updating to 1.10.7; at the same time I think the correct file names should
be used, i.e. jquery.dataTables.min.[css|js] rather than the plain datatables.[css|js] which
is less descriptive.
> The JS file includes a comment with the version and licensing details; unfortunately
the CSS file has no such identification. Perhaps we should add a brief comment? It would also
be possible to document the version in the SVN log message (should do that anyway). Or use
a separate text file, but that would likely get outdated (maybe include the MD5 hash of the
file to identify it)?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message