celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] pnoltes commented on a change in pull request #272: Feature/cpp17 promise
Date Mon, 20 Jul 2020 20:01:31 GMT

pnoltes commented on a change in pull request #272:
URL: https://github.com/apache/celix/pull/272#discussion_r457653259



##########
File path: misc/experimental/promise/CMakeLists.txt
##########
@@ -52,7 +52,7 @@ if (PROMISE OR PROMISE_STANDALONE)
         $<INSTALL_INTERFACE:include/celix/promise>
     )
     target_link_libraries(Promise INTERFACE TBB::tbb Threads::Threads)
-    target_compile_options(Promise INTERFACE -frtti) #Note needed for TBB
+    target_compile_options(Promise INTERFACE -frtti -std=c++17) #Note needed for TBB

Review comment:
       The note, is only for -frtti not c++17




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message