celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] Oipo commented on a change in pull request #267: Make pstm handling thread sleep time configurable
Date Thu, 09 Jul 2020 11:53:08 GMT

Oipo commented on a change in pull request #267:
URL: https://github.com/apache/celix/pull/267#discussion_r452161308



##########
File path: bundles/pubsub/test/CMakeLists.txt
##########
@@ -173,12 +173,6 @@ if (BUILD_PUBSUB_PSA_UDP_MC)
     add_test(NAME pstm_deadlock_udpmc_test COMMAND pstm_deadlock_udpmc_test WORKING_DIRECTORY
$<TARGET_PROPERTY:pstm_deadlock_udpmc_test,CONTAINER_LOC>)
     setup_target_for_coverage(pstm_deadlock_udpmc_test SCAN_DIR ..)
 
-    #TCP Endpoint test is disabled because the test is not stable when running on Travis

Review comment:
       Yes. If you look closely, it's trying to add a TCP test inside of the UDP block. The
TCP block also adds this test, it must've somehow got duplicated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message