From dev-return-2361-apmail-celix-dev-archive=celix.apache.org@celix.apache.org Thu Jun 11 18:29:13 2020 Return-Path: X-Original-To: apmail-celix-dev-archive@www.apache.org Delivered-To: apmail-celix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id F118E19FBB for ; Thu, 11 Jun 2020 18:29:12 +0000 (UTC) Received: (qmail 35353 invoked by uid 500); 11 Jun 2020 18:29:12 -0000 Delivered-To: apmail-celix-dev-archive@celix.apache.org Received: (qmail 35336 invoked by uid 500); 11 Jun 2020 18:29:12 -0000 Mailing-List: contact dev-help@celix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@celix.apache.org Delivered-To: mailing list dev@celix.apache.org Received: (qmail 35317 invoked by uid 99); 11 Jun 2020 18:29:12 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jun 2020 18:29:12 +0000 From: =?utf-8?q?GitBox?= To: dev@celix.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bcelix=5D_rbulter_commented_on_a_change_in_pull_req?= =?utf-8?q?uest_=23253=3A_Feature/proposal_protocol_footer?= Message-ID: <159190015207.8807.3923765928910058675.asfpy@gitbox.apache.org> Date: Thu, 11 Jun 2020 18:29:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: rbulter commented on a change in pull request #253: URL: https://github.com/apache/celix/pull/253#discussion_r438988878 ########## File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_receiver.c ########## @@ -650,6 +650,8 @@ static void* psa_zmq_recvThread(void * data) { } else { message.metadata.metadata = NULL; } + zframe_t *footer = zmsg_pop(zmsg); // footer + receiver->protocol->decodeFooter(receiver->protocol->handle, zframe_data(footer), zframe_size(footer), &message); Review comment: I think this is correct, the code is also changed to make footer optional ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org