From dev-return-2351-apmail-celix-dev-archive=celix.apache.org@celix.apache.org Thu Jun 11 15:31:39 2020 Return-Path: X-Original-To: apmail-celix-dev-archive@www.apache.org Delivered-To: apmail-celix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 4080A19391 for ; Thu, 11 Jun 2020 15:31:39 +0000 (UTC) Received: (qmail 47622 invoked by uid 500); 11 Jun 2020 15:31:38 -0000 Delivered-To: apmail-celix-dev-archive@celix.apache.org Received: (qmail 47589 invoked by uid 500); 11 Jun 2020 15:31:38 -0000 Mailing-List: contact dev-help@celix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@celix.apache.org Delivered-To: mailing list dev@celix.apache.org Received: (qmail 47577 invoked by uid 99); 11 Jun 2020 15:31:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jun 2020 15:31:38 +0000 From: =?utf-8?q?GitBox?= To: dev@celix.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bcelix=5D_pnoltes_commented_on_a_change_in_pull_req?= =?utf-8?q?uest_=23256=3A_Feature/pubsub_utils_test_fix?= Message-ID: <159188949852.8471.17375841518726091390.asfpy@gitbox.apache.org> Date: Thu, 11 Jun 2020 15:31:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: pnoltes commented on a change in pull request #256: URL: https://github.com/apache/celix/pull/256#discussion_r438873946 ########## File path: bundles/pubsub/pubsub_utils/src/pubsub_serialization_provider.c ########## @@ -258,6 +258,21 @@ static dyn_message_type* pubsub_serializationProvider_parseDfiDescriptor(pubsub_ //} //} +/** + * Check if a pubsub serialization entry is already present (exact path) + * + * @return true if the entry is a already present + */ +static bool pubsub_serializationProvider_alreadyAddedEntry(pubsub_serialization_provider_t* provider, pubsub_serialization_entry_t* entry) { Review comment: true, but indeed for now too much work. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org