From dev-return-2336-apmail-celix-dev-archive=celix.apache.org@celix.apache.org Wed Jun 10 19:29:09 2020 Return-Path: X-Original-To: apmail-celix-dev-archive@www.apache.org Delivered-To: apmail-celix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 592381980A for ; Wed, 10 Jun 2020 19:29:09 +0000 (UTC) Received: (qmail 85026 invoked by uid 500); 10 Jun 2020 19:29:08 -0000 Delivered-To: apmail-celix-dev-archive@celix.apache.org Received: (qmail 84996 invoked by uid 500); 10 Jun 2020 19:29:08 -0000 Mailing-List: contact dev-help@celix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@celix.apache.org Delivered-To: mailing list dev@celix.apache.org Received: (qmail 84973 invoked by uid 99); 10 Jun 2020 19:29:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jun 2020 19:29:08 +0000 From: =?utf-8?q?GitBox?= To: dev@celix.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bcelix=5D_pnoltes_commented_on_pull_request_=23253?= =?utf-8?q?=3A_Feature/proposal_protocol_footer?= Message-ID: <159181734863.8471.4441219200404521976.asfpy@gitbox.apache.org> Date: Wed, 10 Jun 2020 19:29:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: pnoltes commented on pull request #253: URL: https://github.com/apache/celix/pull/253#issuecomment-642211354 @rbulter Is it possible to create two wire protocol bundles from the same sources. So a version 1 which encodes the same as released in 2.2.1 and a version 2 which adds the footer. IMO there is no issues with having an internal SPI update, but for now we should also keep the support for the v1 wire protocol. Indeed as Alexander mentioned to ensure alignment with Java. So maybe add an contructor arg to the protocol and a programmatically way to detect if a footer is supported to protocol service, e.g: celix_status_t pubsubProtocol_create(bool addFooterSupport, pubsub_protocol_wire_v1_t **protocol); typedef struct pubsub_protocol_service { ... celix_status_t (*supportsFooter)(void* handle, void *out); ... } ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org