From dev-return-2282-apmail-celix-dev-archive=celix.apache.org@celix.apache.org Fri Jun 5 13:09:14 2020 Return-Path: X-Original-To: apmail-celix-dev-archive@www.apache.org Delivered-To: apmail-celix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id BEE861915E for ; Fri, 5 Jun 2020 13:09:13 +0000 (UTC) Received: (qmail 96092 invoked by uid 500); 5 Jun 2020 13:09:13 -0000 Delivered-To: apmail-celix-dev-archive@celix.apache.org Received: (qmail 96066 invoked by uid 500); 5 Jun 2020 13:09:13 -0000 Mailing-List: contact dev-help@celix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@celix.apache.org Delivered-To: mailing list dev@celix.apache.org Received: (qmail 96053 invoked by uid 99); 5 Jun 2020 13:09:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2020 13:09:13 +0000 From: =?utf-8?q?GitBox?= To: dev@celix.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bcelix=5D_codecov-commenter_edited_a_comment_on_pul?= =?utf-8?q?l_request_=23250=3A_refactor_read_and_write_function?= Message-ID: <159136255305.17834.6923917845604839911.asfpy@gitbox.apache.org> Date: Fri, 05 Jun 2020 13:09:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: codecov-commenter edited a comment on pull request #250: URL: https://github.com/apache/celix/pull/250#issuecomment-639468411 # [Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=h1) Report > Merging [#250](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/f25f19f304d80caf2c41bd21580075a1e935b190&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `63.84%`. [![Impacted file tree graph](https://codecov.io/gh/apache/celix/pull/250/graphs/tree.svg?width=650&height=150&src=pr&token=JdsiThga8P)](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #250 +/- ## ========================================== + Coverage 67.82% 67.86% +0.03% ========================================== Files 127 127 Lines 26375 26384 +9 ========================================== + Hits 17890 17906 +16 + Misses 8485 8478 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `75.17% <63.41%> (-1.03%)` | :arrow_down: | | [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `64.13% <66.66%> (+0.02%)` | :arrow_up: | | [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `63.14% <75.00%> (+0.02%)` | :arrow_up: | | [libs/framework/src/framework.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2ZyYW1ld29yay5j) | `75.52% <0.00%> (+0.21%)` | :arrow_up: | | [libs/utils/src/hash\_map.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-bGlicy91dGlscy9zcmMvaGFzaF9tYXAuYw==) | `95.10% <0.00%> (+2.01%)` | :arrow_up: | | [libs/framework/src/celix\_log.c](https://codecov.io/gh/apache/celix/pull/250/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2NlbGl4X2xvZy5j) | `89.06% <0.00%> (+10.93%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=footer). Last update [f25f19f...9cdf93b](https://codecov.io/gh/apache/celix/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org