celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] pnoltes opened a new pull request #254: Refactors generation and usage of CelixTargets cmake files
Date Tue, 09 Jun 2020 16:17:06 GMT

pnoltes opened a new pull request #254:
URL: https://github.com/apache/celix/pull/254


   Changes how CelixTargets cmake file are generated and used for installs with multiple build
types.
   
   Primary so that there is can be a single CelixTargets.cmake entry point.
   Tthis is needed to not break how Celix (or projects export Celix bundles) Config.cmake
file works.
   
   I ran into the issue that all project using Celix, exporting bundles and providing a <Package>Config.cmake
are not building any more. 
   
   In the refactored setup, there is always a CelixTargets.cmake file and this file includes
all config specific CelixTargets-<Config>.cmake files. 
   
   Also ensure that multiple imported bundle configs can coexists. When creating a container/docker
the correct bundle for the config will be resolved. I tried to mimic as much as possible cmake
behavior for imported library targets. 
   
   This resolving also make use of CMAKE_MAP_IMPORTED_CONFIG_<CONFIG> and target properties
MAP_IMPORTED_CONFIG_<CONFIG> (if present)
   
   I ensured that it will always try to resolve to a imported bundle targets even if no imported
bundle target exists for the build type and no MAP_IMPORT_CONFIG exists. If I am not sure
how CMake handle this for libraries, but this seems logical for me...
   
   I tested this when installed for the CMAKE_BUILD_TYPE Release, Debug and <empty>
using the celix-example dir (which can be build standalone). 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message