celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] Oipo commented on a change in pull request #249: Add env vars for bind/connect urls in pubsub
Date Fri, 12 Jun 2020 08:07:52 GMT

Oipo commented on a change in pull request #249:
URL: https://github.com/apache/celix/pull/249#discussion_r439271452



##########
File path: bundles/http_admin/http_admin/src/activator.c
##########
@@ -61,6 +61,15 @@ static int http_admin_start(http_admin_activator_t *act, celix_bundle_context_t
     long prop_port_max = celix_bundleContext_getPropertyAsLong(ctx, HTTP_ADMIN_PORT_RANGE_MAX_KEY,
HTTP_ADMIN_PORT_RANGE_MAX_DFT);
     long num_threads = celix_bundleContext_getPropertyAsLong(ctx, HTTP_ADMIN_NUM_THREADS_KEY,
HTTP_ADMIN_NUM_THREADS_DFT);
 
+    const char* listPortEnv = getenv(HTTP_ADMIN_LISTENING_PORTS_KEY);

Review comment:
       But then you would not be able to override the bundle properties with an env var?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message