celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] rbulter commented on a change in pull request #253: Feature/proposal protocol footer
Date Thu, 11 Jun 2020 18:28:38 GMT

rbulter commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r438988614



##########
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_receiver.c
##########
@@ -650,6 +650,8 @@ static void* psa_zmq_recvThread(void * data) {
                 } else {
                     message.metadata.metadata = NULL;
                 }
+                zframe_t *footer = zmsg_pop(zmsg); // footer

Review comment:
       I think this correct, also the code is updated because footer is optional




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message