celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] pnoltes commented on pull request #253: Feature/proposal protocol footer
Date Wed, 10 Jun 2020 19:29:08 GMT

pnoltes commented on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-642211354


   @rbulter Is it possible to create two wire protocol bundles from the same sources.
   
   So a version 1 which encodes the same as released in 2.2.1 and a version 2 which adds the
footer.
   
   IMO there is no issues with having an internal SPI update, but for now we should also keep
the support for the v1 wire protocol. Indeed as Alexander mentioned to ensure alignment with
Java.
   
   So maybe add an contructor arg to the protocol and a programmatically way to detect if
a footer is supported to protocol service, e.g:
   
   celix_status_t pubsubProtocol_create(bool addFooterSupport, pubsub_protocol_wire_v1_t **protocol);
   
   typedef struct pubsub_protocol_service {
    ...
   celix_status_t (*supportsFooter)(void* handle, void *out);
   ...
   }


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message