pnoltes commented on a change in pull request #254:
URL: https://github.com/apache/celix/pull/254#discussion_r437176462
##########
File path: cmake/cmake_celix/BundlePackaging.cmake
##########
@@ -201,13 +201,19 @@ function(add_celix_bundle)
endif ()
- set(BUNDLE_FILENAME ${BASE_BUNDLE_FILENAME}-${CMAKE_BUILD_TYPE}.zip)
- foreach (NO_POSTFIX_BT IN LISTS CELIX_NO_POSTFIX_BUILD_TYPES)
- if (CMAKE_BUILD_TYPE STREQUAL NO_POSTFIX_BT)
- #setting bundle file name without postfix
- set(BUNDLE_FILENAME ${BASE_BUNDLE_FILENAME}.zip)
- endif ()
- endforeach ()
+ if (CMAKE_BUILD_TYPE)
Review comment:
yes, it can be empty
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
|