celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on pull request #253: Feature/proposal protocol footer
Date Tue, 09 Jun 2020 16:07:12 GMT

abroekhuis commented on pull request #253:
URL: https://github.com/apache/celix/pull/253#issuecomment-641057905


   > Note: If we accept this PR. We should align it with the Java PubSub impl
   
   I would even go a bit further. At this moment the wireprotocol is released as version 1.0.
If we do this, we are creating a new version, and IMO should handle it as such. 
   Since we just released 2.2.1, I do think we should create a new bundle next to the 1.0
version. To be able to use the footer, the protocol service needs to be updated. I propose
to add a "hasFooter() : bool" to it so that the sender/receiver can use that to determine
if a footer needs to be processed.
   Version 1.0 of the wireprotocol can be updated to have this call so that the actual protocol
can stay the same.
   A new version, 1.1, can be created that has the actual footer.
   
   Please note: for our own usage I don't see any big risks in _not_ keeping the 1.0 version
around. But since we just did a release AND it currently is compatible with the Java PubSub,
we need to be a cautious here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message