celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on a change in pull request #245: Bugfix/data races
Date Mon, 08 Jun 2020 10:01:08 GMT

abroekhuis commented on a change in pull request #245:
URL: https://github.com/apache/celix/pull/245#discussion_r436585222



##########
File path: bundles/http_admin/test/test/http_websocket_tests.cc
##########
@@ -222,7 +222,8 @@ TEST(HTTP_ADMIN_INT_GROUP, websocket_echo_test) {
 
     usleep(1000000); //Sleep for one second to let Civetweb handle the request
 
-    //Check if data received is the same as the data sent!
+    // ThreadSanitizer reports a potential data race on the data field, but can be ignored.

Review comment:
       Both only runtime, perhaps good to document somewhere. 
   
   Since this is a test, can we add the file or options to the execution of it?
   That way we do not run into CI errors due to this false positive.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message