celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on pull request #251: Removes usage of cmake IF(IN_LIST), for some env this gives problems.
Date Mon, 08 Jun 2020 08:26:36 GMT

abroekhuis commented on pull request #251:
URL: https://github.com/apache/celix/pull/251#issuecomment-640450518

   > > I'm going to object this one. Not sure what the issue is, some details might
convinced me otherwise.
   > > But, in_list is already in cmake since 3.3. And more importantly, we should not
want to fix down stream issues with such old versions. Some backwards compatibility with older
versions is good, but this goes back to far.
   > Tested with cmake 3.4 and 3.12 and in both cases the cmake policy CMP0057 has te be
set (I expect to NEW) or the build fails.
   > Normally not a big issues, just set the policy in Celix.
   > But because the BundlePackaging.cmake is a Celix delivery and used by end users, this
means that all users using at least cmake <= 3.12 need to set this policy in their environment
or else the build will fail.
   3.12 has been release in november 2018, I don't see a big problem here. If it was less
then a year ago, perhaps, but not now.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message