celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] pnoltes commented on pull request #223: Feature/pubsub custom serializers
Date Mon, 18 May 2020 09:46:45 GMT

pnoltes commented on pull request #223:
URL: https://github.com/apache/celix/pull/223#issuecomment-630071770


   > Looks good, but please please please, make PR's smaller. This touched so many things,
that should have been in different PR's...
   > Smaller PR's makes reviewing much easier.
   
   Yeah I understand that. My bad for adding the FindCppuTest stuff. 
   
   Note that I ran into the tracking bundles issues when developing the pubsub msg serialization
bundles. So splitting is not really an option then. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message