celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] pnoltes commented on pull request #234: Only disable optimizations for specific test, rather than entire celix
Date Mon, 18 May 2020 06:38:18 GMT

pnoltes commented on pull request #234:
URL: https://github.com/apache/celix/pull/234#issuecomment-629977050


   > While this does work, I don't feel really comfortable with it. Even though this test
triggers the problem, the problem also seems to come from the ffi library.
   > Are we certain it is due to the test? And if not, how certain are we that this will
not happen in a released version?
   > 
   > @pnoltes wdyt?
   > 
   > Having said that, I'm fine with approving it, as long as we remember this is an issue,
if it comes up again.
   
   I do think it is our tests/usage. libffi is to heavily used and as result I think it is
more likely that it is our code. But this is an assumption. 
   I also have not experienced problems with libdfi (using libffi) using it in our company
systems. 
   
   So I think we should allow this fix, but keep an sharp eye on any problems we with pubsub/rsa.



----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message