celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on a change in pull request #227: Update build documentation for Ubuntu.
Date Thu, 14 May 2020 18:09:12 GMT

abroekhuis commented on a change in pull request #227:
URL: https://github.com/apache/celix/pull/227#discussion_r425335541



##########
File path: documents/building/README.md
##########
@@ -66,6 +66,11 @@ sudo apt-get install -yq --no-install-recommends \
 #required if the ENABLE_TESTING option is enabled
 sudo apt-get install -yq --no-install-recommends \
     libcpputest-dev
+
+#For testing gtest is also used. This is fetched using a cmake 3.11+ feature,

Review comment:
       Was an old remark, I always forget to post the review. Kinda used to adding it, and
expecting it to be available. Instead of having to actually submit it ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message