celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] Oipo commented on a change in pull request #228: Feature/support multiple build types
Date Sun, 10 May 2020 19:57:38 GMT

Oipo commented on a change in pull request #228:
URL: https://github.com/apache/celix/pull/228#discussion_r422692075



##########
File path: .github/workflows/macos-nightly.yml
##########
@@ -0,0 +1,40 @@
+name: Celix MacOS Nightly
+
+on:
+  schedule:
+    - cron:  '0 0 * * *'
+
+jobs:
+  build:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [macOS-latest]
+        compiler: [clang]
+    timeout-minutes: 120
+    steps:
+    - name: Checkout source code
+      uses: actions/checkout@master
+    - name: Install dependencies
+      run: |
+        brew update
+        brew install lcov zeromq czmq openssl cpputest
+        brew unlink openssl && brew link openssl --force
+    - name: Build
+      env:
+        CC: ${{ matrix.compiler }}
+        BUILD_OPTIONS: |
+          -DENABLE_TESTING=ON
+          -DENABLE_ADDRESS_SANITIZER=ON
+      run: |
+        mkdir build install
+        cd build
+        cmake -DCMAKE_BUILD_TYPE=Release ${BUILD_OPTIONS} -DCMAKE_INSTALL_PREFIX=../install
..

Review comment:
       Specifically compiling this branch with Debug mode, running libs/dfi/gtest/test_dfi
gives me the following backtrace:
   ```
   #0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
   #1  0x00007ffff7b6a899 in __GI_abort () at abort.c:79
   #2  0x00007ffff7b6a769 in __assert_fail_base (fmt=0x7ffff7cfefb8 "%s%s%s:%u: %s%sAssertion
`%s' failed.\n%n", assertion=0x5555555fbaf5 "desc != NULL", file=0x5555555fba50 "/home/oipo-unencrypted/Programming/celix-apache/libs/dfi/gtest/src/dyn_interface_tests.cpp",
line=73, function=<optimized out>) at assert.c:92
   #3  0x00007ffff7b7c006 in __GI___assert_fail (assertion=0x5555555fbaf5 "desc != NULL",
file=0x5555555fba50 "/home/oipo-unencrypted/Programming/celix-apache/libs/dfi/gtest/src/dyn_interface_tests.cpp",
line=73, function=0x5555555fbae8 "void test1()") at assert.c:101
   #4  0x00005555555817de in test1 () at /home/oipo-unencrypted/Programming/celix-apache/libs/dfi/gtest/src/dyn_interface_tests.cpp:73
   #5  0x0000555555583269 in DynInterfaceTests_test1_Test::TestBody (this=0x55555566ac00)
at /home/oipo-unencrypted/Programming/celix-apache/libs/dfi/gtest/src/dyn_interface_tests.cpp:205
   #6  0x00005555555e1cc5 in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,
void> (object=0x55555566ac00, method=&virtual testing::Test::TestBody(), location=0x555555606243
"the test body")
       at /home/oipo-unencrypted/Programming/celix-apache/build/_deps/googletest-src/googletest/src/gtest.cc:2433
   #7  0x00005555555da58d in testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
void> (object=0x55555566ac00, method=&virtual testing::Test::TestBody(), location=0x555555606243
"the test body") at /home/oipo-unencrypted/Programming/celix-apache/build/_deps/googletest-src/googletest/src/gtest.cc:2469
   #8  0x00005555555b4ed2 in testing::Test::Run (this=0x55555566ac00) at /home/oipo-unencrypted/Programming/celix-apache/build/_deps/googletest-src/googletest/src/gtest.cc:2508
   #9  0x00005555555b58bd in testing::TestInfo::Run (this=0x55555565a270) at /home/oipo-unencrypted/Programming/celix-apache/build/_deps/googletest-src/googletest/src/gtest.cc:2684
   #10 0x00005555555b5ff8 in testing::TestSuite::Run (this=0x55555565a440) at /home/oipo-unencrypted/Programming/celix-apache/build/_deps/googletest-src/googletest/src/gtest.cc:2816
   #11 0x00005555555c20b4 in testing::internal::UnitTestImpl::RunAllTests (this=0x5555556521b0)
at /home/oipo-unencrypted/Programming/celix-apache/build/_deps/googletest-src/googletest/src/gtest.cc:5338
   #12 0x00005555555e31ee in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool> (object=0x5555556521b0, method=(bool (testing::internal::UnitTestImpl::*)(class testing::internal::UnitTestImpl
* const)) 0x5555555c1cac <testing::internal::UnitTestImpl::RunAllTests()>, 
       location=0x555555606c80 "auxiliary test code (environments or event listeners)") at
/home/oipo-unencrypted/Programming/celix-apache/build/_deps/googletest-src/googletest/src/gtest.cc:2433
   #13 0x00005555555db7cb in testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool> (object=0x5555556521b0, method=(bool (testing::internal::UnitTestImpl::*)(class testing::internal::UnitTestImpl
* const)) 0x5555555c1cac <testing::internal::UnitTestImpl::RunAllTests()>, 
       location=0x555555606c80 "auxiliary test code (environments or event listeners)") at
/home/oipo-unencrypted/Programming/celix-apache/build/_deps/googletest-src/googletest/src/gtest.cc:2469
   #14 0x00005555555c08f4 in testing::UnitTest::Run (this=0x55555563f940 <testing::UnitTest::GetInstance()::instance>)
at /home/oipo-unencrypted/Programming/celix-apache/build/_deps/googletest-src/googletest/src/gtest.cc:4925
   #15 0x00005555555f597f in RUN_ALL_TESTS () at /home/oipo-unencrypted/Programming/celix-apache/build/_deps/googletest-src/googletest/include/gtest/gtest.h:2473
   #16 0x00005555555f5901 in main (argc=1, argv=0x7fffffffdbb8) at /home/oipo-unencrypted/Programming/celix-apache/build/_deps/googletest-src/googletest/src/gtest_main.cc:45
   ```
   
   Compiling with debug and -O2 and running bundles/remote_services/remote_service_admin_dfi/gtest/test_rsa_dfi
gives me the following failed tests:
   ```
   [==========] Running 11 tests from 2 test suites.
   [----------] Global test environment set-up.
   [----------] 4 tests from RsaDfiTests
   [ RUN      ] RsaDfiTests.InfoTest
   /home/oipo-unencrypted/Programming/celix-apache/bundles/remote_services/remote_service_admin_dfi/gtest/src/rsa_tests.cc:40:
Failure
   Value of: fwProperties != NULL
     Actual: false
   Expected: true
   [  FAILED  ] RsaDfiTests.InfoTest (0 ms)
   [ RUN      ] RsaDfiTests.ExportService
   /home/oipo-unencrypted/Programming/celix-apache/bundles/remote_services/remote_service_admin_dfi/gtest/src/rsa_tests.cc:40:
Failure
   Value of: fwProperties != NULL
     Actual: false
   Expected: true
   [  FAILED  ] RsaDfiTests.ExportService (0 ms)
   [ RUN      ] RsaDfiTests.ImportService
   /home/oipo-unencrypted/Programming/celix-apache/bundles/remote_services/remote_service_admin_dfi/gtest/src/rsa_tests.cc:40:
Failure
   Value of: fwProperties != NULL
     Actual: false
   Expected: true
   [  FAILED  ] RsaDfiTests.ImportService (0 ms)
   [ RUN      ] RsaDfiTests.TestBundles
   /home/oipo-unencrypted/Programming/celix-apache/bundles/remote_services/remote_service_admin_dfi/gtest/src/rsa_tests.cc:40:
Failure
   Value of: fwProperties != NULL
     Actual: false
   Expected: true
   [  FAILED  ] RsaDfiTests.TestBundles (0 ms)
   [----------] 4 tests from RsaDfiTests (0 ms total)
   
   [----------] 7 tests from RsaDfiClientServerTests
   [ RUN      ] RsaDfiClientServerTests.TestRemoteCalculator
   /home/oipo-unencrypted/Programming/celix-apache/bundles/remote_services/remote_service_admin_dfi/gtest/src/rsa_client_server_tests.cc:47:
Failure
   Value of: serverProps != NULL
     Actual: false
   Expected: true
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteCalculator (0 ms)
   [ RUN      ] RsaDfiClientServerTests.TestRemoteComplex
   /home/oipo-unencrypted/Programming/celix-apache/bundles/remote_services/remote_service_admin_dfi/gtest/src/rsa_client_server_tests.cc:47:
Failure
   Value of: serverProps != NULL
     Actual: false
   Expected: true
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteComplex (0 ms)
   [ RUN      ] RsaDfiClientServerTests.TestRemoteNumbers
   /home/oipo-unencrypted/Programming/celix-apache/bundles/remote_services/remote_service_admin_dfi/gtest/src/rsa_client_server_tests.cc:47:
Failure
   Value of: serverProps != NULL
     Actual: false
   Expected: true
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteNumbers (0 ms)
   [ RUN      ] RsaDfiClientServerTests.TestRemoteString
   /home/oipo-unencrypted/Programming/celix-apache/bundles/remote_services/remote_service_admin_dfi/gtest/src/rsa_client_server_tests.cc:47:
Failure
   Value of: serverProps != NULL
     Actual: false
   Expected: true
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteString (0 ms)
   [ RUN      ] RsaDfiClientServerTests.TestRemoteConstString
   /home/oipo-unencrypted/Programming/celix-apache/bundles/remote_services/remote_service_admin_dfi/gtest/src/rsa_client_server_tests.cc:47:
Failure
   Value of: serverProps != NULL
     Actual: false
   Expected: true
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteConstString (0 ms)
   [ RUN      ] RsaDfiClientServerTests.TestRemoteEnum
   /home/oipo-unencrypted/Programming/celix-apache/bundles/remote_services/remote_service_admin_dfi/gtest/src/rsa_client_server_tests.cc:47:
Failure
   Value of: serverProps != NULL
     Actual: false
   Expected: true
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteEnum (0 ms)
   [ RUN      ] RsaDfiClientServerTests.TestRemoteAction
   /home/oipo-unencrypted/Programming/celix-apache/bundles/remote_services/remote_service_admin_dfi/gtest/src/rsa_client_server_tests.cc:47:
Failure
   Value of: serverProps != NULL
     Actual: false
   Expected: true
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteAction (0 ms)
   [----------] 7 tests from RsaDfiClientServerTests (0 ms total)
   
   [----------] Global test environment tear-down
   [==========] 11 tests from 2 test suites ran. (0 ms total)
   [  PASSED  ] 0 tests.
   [  FAILED  ] 11 tests, listed below:
   [  FAILED  ] RsaDfiTests.InfoTest
   [  FAILED  ] RsaDfiTests.ExportService
   [  FAILED  ] RsaDfiTests.ImportService
   [  FAILED  ] RsaDfiTests.TestBundles
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteCalculator
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteComplex
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteNumbers
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteString
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteConstString
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteEnum
   [  FAILED  ] RsaDfiClientServerTests.TestRemoteAction
   ```
   
   Compiling in release mode with -O2 and running bundles/remote_services/remote_service_admin_dfi/gtest/test_rsa_dfi
gives me a segfault:
   ```
   #0  0x00007ffff7b49fdb in ffi_call () from /lib/x86_64-linux-gnu/libffi.so.6
   #1  0x00007ffff7fb7b51 in dynFunction_call () from /home/oipo-unencrypted/Programming/celix-apache/build/libs/dfi/libcelix_dfi.so.1
   #2  0x0000555555581873 in DynFunctionTests_DynFuncTest3_Test::TestBody() ()
   #3  0x00005555555d9de1 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
void>(testing::Test*, void (testing::Test::*)(), char const*) ()
   #4  0x00005555555cd3ea in testing::Test::Run() [clone .part.0] ()
   #5  0x00005555555cd882 in testing::TestInfo::Run() [clone .part.0] ()
   #6  0x00005555555cda8e in testing::TestSuite::Run() [clone .part.0] ()
   #7  0x00005555555ceb4d in testing::internal::UnitTestImpl::RunAllTests() ()
   #8  0x00005555555cf0b8 in testing::UnitTest::Run() ()
   #9  0x0000555555577b34 in main ()
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message