celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on a change in pull request #228: Feature/support multiple build types
Date Sun, 10 May 2020 18:45:54 GMT

abroekhuis commented on a change in pull request #228:
URL: https://github.com/apache/celix/pull/228#discussion_r422683558



##########
File path: .github/workflows/macos-nightly.yml
##########
@@ -0,0 +1,40 @@
+name: Celix MacOS Nightly
+
+on:
+  schedule:
+    - cron:  '0 0 * * *'
+
+jobs:
+  build:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [macOS-latest]
+        compiler: [clang]
+    timeout-minutes: 120
+    steps:
+    - name: Checkout source code
+      uses: actions/checkout@master
+    - name: Install dependencies
+      run: |
+        brew update
+        brew install lcov zeromq czmq openssl cpputest
+        brew unlink openssl && brew link openssl --force
+    - name: Build
+      env:
+        CC: ${{ matrix.compiler }}
+        BUILD_OPTIONS: |
+          -DENABLE_TESTING=ON
+          -DENABLE_ADDRESS_SANITIZER=ON
+      run: |
+        mkdir build install
+        cd build
+        cmake -DCMAKE_BUILD_TYPE=Release ${BUILD_OPTIONS} -DCMAKE_INSTALL_PREFIX=../install
..

Review comment:
       Are you now also referring to the disabled optimization? Because that one does fail
due to tetst_dfi.
   Also, specifically due to some strange behaviour in the ffi lib itself. It might be memory
leaks...
   Anyway, whatever it is, since test_dfi fails with O1 (or 2 or 3) due to an external lib,
I don't think it is wise to disable a test and build with optimization. Since the actual problem
of that case is not in the test..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message