celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on a change in pull request #228: Feature/support multiple build types
Date Fri, 08 May 2020 18:37:30 GMT

abroekhuis commented on a change in pull request #228:
URL: https://github.com/apache/celix/pull/228#discussion_r421735221



##########
File path: libs/framework/gtest/CMakeLists.txt
##########
@@ -15,14 +15,17 @@
 # specific language governing permissions and limitations
 # under the License.
 
+# Set buildtype as define so that in the test code we can use the proper bundle names
+add_definitions ( -DBUILD_TYPE=\"${CMAKE_BUILD_TYPE}\" )
+
 add_celix_bundle(simple_test_bundle1 NO_ACTIVATOR VERSION 1.0.0)
 add_celix_bundle(simple_test_bundle2 NO_ACTIVATOR VERSION 1.0.0)
 add_celix_bundle(simple_test_bundle3 NO_ACTIVATOR VERSION 1.0.0)
 add_celix_bundle(bundle_with_exception SOURCES src/nop_activator.c VERSION 1.0.0)
 add_subdirectory(subdir) #simple_test_bundle4, simple_test_bundle5 and sublib
 
 add_celix_bundle(unresolveable_bundle SOURCES src/nop_activator.c VERSION 1.0.0)
-target_link_libraries(unresolveable_bundle PRIVATE "-L${CMAKE_CURRENT_BINARY_DIR}/subdir
-lsublib")
+target_link_libraries(unresolveable_bundle PRIVATE sublib)

Review comment:
       Was this done with a reason? If so, this needs to be reverted, and updated to use the
build type postfix for debug.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message