Oipo commented on a change in pull request #181: Updated ZMQ implementation to use NULL if scope is not set. Only when…
URL: https://github.com/apache/celix/pull/181#discussion_r400790569
 
 

 ##########
 File path: bundles/pubsub/pubsub_api/include/pubsub/subscriber.h
 ##########
 @@ -39,7 +39,7 @@
 #define PUBSUB_SUBSCRIBER_SCOPE                "scope"
 #define PUBSUB_SUBSCRIBER_CONFIG               "pubsub.config"
 
-#define PUBSUB_SUBSCRIBER_SCOPE_DEFAULT        "default"
+//#define PUBSUB_SUBSCRIBER_SCOPE_DEFAULT        "default"
 
 Review comment:
   Why comment out the subscriber but not the publisher?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services