From dev-return-1760-apmail-celix-dev-archive=celix.apache.org@celix.apache.org Wed Mar 11 18:50:20 2020 Return-Path: X-Original-To: apmail-celix-dev-archive@www.apache.org Delivered-To: apmail-celix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 11E4619CC1 for ; Wed, 11 Mar 2020 18:50:19 +0000 (UTC) Received: (qmail 33843 invoked by uid 500); 11 Mar 2020 18:50:19 -0000 Delivered-To: apmail-celix-dev-archive@celix.apache.org Received: (qmail 33818 invoked by uid 500); 11 Mar 2020 18:50:19 -0000 Mailing-List: contact dev-help@celix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@celix.apache.org Delivered-To: mailing list dev@celix.apache.org Received: (qmail 33806 invoked by uid 99); 11 Mar 2020 18:50:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Mar 2020 18:50:19 +0000 From: GitBox To: dev@celix.apache.org Subject: [GitHub] [celix] pnoltes commented on a change in pull request #169: auto install then start bundles Message-ID: <158395261933.21775.969837215173377945.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 11 Mar 2020 18:50:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit pnoltes commented on a change in pull request #169: auto install then start bundles URL: https://github.com/apache/celix/pull/169#discussion_r391190574 ########## File path: cmake/cmake_celix/ContainerPackaging.cmake ########## @@ -408,7 +408,7 @@ endfunction() Add the selected bundles to the Celix container. These bundles are (if configured) copied to the container build dir and are added to the configuration properties so that they are installed and started when the Celix container executed. -The Celix framework support 7 (0 - 6) run levels. Run levels can be used to control the start and stop order of bundles. +The Celix framework supports 7 (0 - 6) run levels. Run levels can be used to control the start and stop order of bundles. Review comment: Yeah I think that is possible, but because the main function for a celix container is generated with cmake (generator-expression), I am afraid this will be complex. So for now I would like to keep it at the fixed runtime levels. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services