celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] rbulter commented on issue #172: Refactor TcpAdmin and add interfacing for VectorIoSerialisation
Date Tue, 31 Mar 2020 15:08:22 GMT
rbulter commented on issue #172: Refactor TcpAdmin and add interfacing for VectorIoSerialisation
URL: https://github.com/apache/celix/pull/172#issuecomment-606686715
 
 
   > IMO this PR exposes a lot of technical details to all Admins, I don't like it, for
example, iovec is now used in all admins.
   > I even wonder if these changes should not go in an own protocol, since it is now heavily
extending the wireprotocol.
   > We should keep in mind that this code is in the public domain, and should be useable
and simple enough for others to use and read. This PR heavily complicates this, and I don't
think we should merge this as it is now.
   
   I have extended the protocol_interface with functions that are needed for 
   plain socket admins.  ZMQ does not need this. Because ZMQ add it's own header 
   before the protocol header. Without the protocol changes the it's only useable with ZMQ.
   The wire admin changes are because of the protocol interfaces changes and 
   are not related to iovec change.
   
   The iovec structure is only used for serialisation ./ deserialisation.
   It was the suggestion of Pepijn to change the serialize / deserialize interface to use
iovec.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message