celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] Oipo commented on a change in pull request #181: Updated ZMQ implementation to use NULL if scope is not set. Only when…
Date Tue, 31 Mar 2020 10:12:23 GMT
Oipo commented on a change in pull request #181: Updated ZMQ implementation to use NULL if
scope is not set. Only when…
URL: https://github.com/apache/celix/pull/181#discussion_r400772025
 
 

 ##########
 File path: bundles/pubsub/pubsub_spi/src/pubsub_endpoint.c
 ##########
 @@ -194,7 +196,11 @@ bool pubsubEndpoint_equals(const celix_properties_t *psEp1, const celix_properti
 
 char* pubsubEndpoint_createScopeTopicKey(const char* scope, const char* topic) {
     char *result = NULL;
-    asprintf(&result, "%s:%s", scope, topic);
+    if (scope != NULL) {
+        asprintf(&result, "%s:%s", scope, topic);
+    } else {
+        asprintf(&result, "default:%s", topic);
 
 Review comment:
   Here, too, I expect PUBSUB_SCOPE_DEFAULT

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message