celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] pnoltes commented on a change in pull request #139: Add parsing of version and filter on version when calling useService*.
Date Sun, 12 Jan 2020 14:32:19 GMT
pnoltes commented on a change in pull request #139: Add parsing of version and filter on version
when calling useService*.
URL: https://github.com/apache/celix/pull/139#discussion_r365586926
 
 

 ##########
 File path: libs/framework/src/service_tracker.c
 ##########
 @@ -32,6 +32,8 @@
 #include "celix_log.h"
 #include "bundle_context_private.h"
 #include "celix_array_list.h"
+#include "../../utils/src/version_range_private.h"
 
 Review comment:
   Do not include with relative paths and do not include "private" headers (headers in the
src dirs).
   
   I would prefer that a function for transforming a version ranges to ldap filter is added
to the utils library:
   
   typedef struct versionRange version_range_t;
   
   /**
    * Returns the LDAP filter for a version range. Caller is owner of the returned string.
    * If version range is not valid, NULL will be returned.
    */
   char* versionRange_createLDAPFilter(version_range_t *range)
   
   /**
    * construct a LDAP filter for the provided version range. 
   * The string will be created in the provided buffer, if the buffer is big enough.
   *  Returns true if successful. 
    */
   bool versionRange_constructLDAPFilter(version_range_t *range, char* buffer, size_t bufferLength);
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message