celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bjoern Petri <bjoern.pe...@sundevil.de>
Subject Re: [jira] [Closed] (CELIX-169) Add port collision auto-correction to discovery
Date Wed, 22 Oct 2014 20:21:50 GMT

Hi Alexander,

I cannot disagree - having the additional functionality you're 
describing would be preferable. So feel free to open an issue for that 
and assign it to me. But because the same mechanism is used for rsa http 
and the discovery endpoint server this would also confirm the need to 
have the code placed at one location, shared by rsa&discovery. And 
although this belongs to remote services  and therefore could be put 
directly below remote services, I don't feel that comfortable spreading 
shared code everywhere. An alternative might be to also (or in addition) 
have some common functionality to parsing the used syntax and put this 
next to the other util functionality - but I am also not convinced of 
that one. How would you do it?

Regards,
   Bjoern


On October 22, 2014 2:06:58 PM Alexander Broekhuis 
<a.broekhuis@gmail.com> wrote:

> Hi Bjoern,
> 
> Even though you already closed this one, I'd like to discuss it a bit.
> 
> I think having a more dynamic solution for the port is great, but I 
> also
> would like to be able to fix it to one port. Is it an idea to use the 
> same
> solution that is used for the OSGi Http service? See [1] for the 
> complete
> details. Basically this means that the variable is used to supply some
> information about how the port is determined. For example, only 
> supplying
> 8000 would mean that 8000 should be used, if 8000 is not available, 
> simple
> fail. Using [8000,9000) means any port in the range from 8000 inclusive 
> to
> 9000 exclusive will be used.
> 
> What do you think?
> 
> [1]:
> http://felix.apache.org/documentation/subprojects/apache-felix-http-service.html#http-port-settings
> 
> 2014-10-19 10:16 GMT-04:00 Bjoern Petri (JIRA) <jira@apache.org>:
> 
> >
> >      [
> > https://issues.apache.org/jira/browse/CELIX-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > ]
> >
> > Bjoern Petri closed CELIX-169.
> > ------------------------------
> >     Resolution: Fixed
> >
> > > Add port collision auto-correction to discovery
> > > -----------------------------------------------
> > >
> > >                 Key: CELIX-169
> > >                 URL: https://issues.apache.org/jira/browse/CELIX-169
> > >             Project: Celix
> > >          Issue Type: Improvement
> > >            Reporter: Bjoern Petri
> > >            Assignee: Bjoern Petri
> > >
> > > Discovery currently neither reports nor tries to correct a port
> > collision when starting. The implemented solution increases the port number
> > by one and tries to start the discovery-webserver again.
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v6.3.4#6332)
> >
> 
> 
> 
> --
> Met vriendelijke groet,
> 
> Alexander Broekhuis



Mime
View raw message