celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Broekhuis <a.broekh...@gmail.com>
Subject Re: [jira] [Updated] (CELIX-105) Fixed array_list_test
Date Tue, 14 Jan 2014 07:12:36 GMT
Hi Bjoern,

While this patch does fix the failing test, I do have 2 remarks.

First one: The test is failing due to a faulty commit from my side. I've
cleaned up the array_list a while back, and probably because of some
testing I updated the default size to 1000. This was never supposed to be
committed. I'll revert it back to 10 today (before the release).

If any of the tests fail, please look into the underlying cause, and don't
assume the test is wrong. All test should be working, I'll make sure they
do before releasing.

Second one: You are now a committer, and while creating an issue is needed
to keep track of changes etc, you can simply commit changes yourself :). No
need for the patch attachment.


2014/1/13 Bjoern Petri (JIRA) <jira@apache.org>

>
>      [
> https://issues.apache.org/jira/browse/CELIX-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Bjoern Petri updated CELIX-105:
> -------------------------------
>
>     Attachment: fix_array_list_test.patch
>
> > Fixed array_list_test
> > ---------------------
> >
> >                 Key: CELIX-105
> >                 URL: https://issues.apache.org/jira/browse/CELIX-105
> >             Project: Celix
> >          Issue Type: Bug
> >            Reporter: Bjoern Petri
> >            Priority: Minor
> >         Attachments: fix_array_list_test.patch
> >
> >
> > I fixed some minor issues within the array_list test
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.1.5#6160)
>



-- 
Met vriendelijke groet,

Alexander Broekhuis

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message