celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Broekhuis <a.broekh...@gmail.com>
Subject Re: [VOTE] Release Celix version 1.0.0.incubating
Date Mon, 20 Jan 2014 07:10:10 GMT
Hi Karl and Marcel,

Thanks for reviewing and voting. I'll add issues/todo's for those points.

Hopefully Roman can find some time to review the release as well.


2014/1/19 Karl Pauls <karlpauls@gmail.com>

> +1
>
> as marrs points out, the copyright year should be updated and I noticed you
> do use a couple of libraries (e.g., mini zip, md5, etc.) which isn't really
> reflected in the top-level files. I would include some "dependencies" file
> or something where you can give credit (especially as their license is
> asking for it nicely :-).
>
> regards,
>
> Karl
>
>
> On Sun, Jan 19, 2014 at 9:18 PM, Marcel Offermans <
> marcel.offermans@luminis.eu> wrote:
>
> > +1 (binding)
> >
> > Validated the checksums and signature.
> > Setup the build system and built the framework and some of the modules.
> > Looked at a few random files and checked them for the correct license
> > header.
> >
> > A small note:
> > The NOTICE file should be updated, it now states 2012, whilst it should
> > reflect all the years, so 2012-2014. That's not a showstopper as far as I
> > know, but should be fixed for the next release.
> >
> > Good release guys!
> >
> > Greetings, Marcel
> >
> >
>
>
> --
> Karl Pauls
> karlpauls@gmail.com
> http://twitter.com/karlpauls
> http://www.linkedin.com/in/karlpauls
> https://profiles.google.com/karlpauls
>



-- 
Met vriendelijke groet,

Alexander Broekhuis

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message