celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pepijn Noltes <pepijnnol...@gmail.com>
Subject Re: [jira] [Updated] (CELIX-75) CMake does not install the Deployment Admin bundle
Date Wed, 25 Sep 2013 12:15:53 GMT
Hi All,


On Thu, Sep 19, 2013 at 9:02 PM, Alexander Broekhuis
<a.broekhuis@gmail.com> wrote:
> Hi all,
>
> I have been looking at this patch, and would like to make a bit more
> changes wrt the install targets.
>
> Currently there is one useable install command: install-release. This
> release has the framework and also bundles can be added.
>
> And this is what I like to change. From a release point of view it doesn't
> always make sense to install all bundles.
>
> In the new setup I want to add an install target per bundle. So for example
> for the deployment admin there will be a install-deployment_admin. This can
> be done by the existing bundle macro, so it will be transparent to the user.
>
> To this end I'd like to extend the bundle macro to also have a parameter
> for the bundle and the headers that need to be installed.
>
> In addition, these install targets can be grouped in one "bundles" install
> target. Which in turn can be combined with the framework install target
> into an release-all target which installs everything.
>
> What do you guys think?

Good idea, with this solution users can just install everything or
cherry pick precisely what they want.
I would also add a install-all-bundles target. The use case being if a
user wants to install all bundles, but not at the same location as the
framework (e.g. framework system wide, bundles on user level).


>
>
> 2013/8/6 Mike van Dongen (JIRA) <jira@apache.org>
>
>>
>>      [
>> https://issues.apache.org/jira/browse/CELIX-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>
>> Mike van Dongen updated CELIX-75:
>> ---------------------------------
>>
>>     Attachment: deployment_admin_install_library.patch
>>
>> This patch will fix this issue.
>> It adds one line which will copy the bundle the same way as the others.
>>
>> > CMake does not install the Deployment Admin bundle
>> > --------------------------------------------------
>> >
>> >                 Key: CELIX-75
>> >                 URL: https://issues.apache.org/jira/browse/CELIX-75
>> >             Project: Celix
>> >          Issue Type: Bug
>> >            Reporter: Mike van Dongen
>> >         Attachments: deployment_admin_install_library.patch
>> >
>> >
>> > CMake does build the deployment_admin.zip, but when executing `make
>> install-release` it does not install this bundle.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>
>
>
> --
> Met vriendelijke groet,
>
> Alexander Broekhuis

Mime
View raw message