celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Broekhuis <a.broekh...@gmail.com>
Subject Re: [jira] [Updated] (CELIX-75) CMake does not install the Deployment Admin bundle
Date Fri, 20 Sep 2013 16:45:53 GMT
Hi Mike,

2013/9/20 Mike van Dongen <celix@mikevandongen.nl>

>
> Would it make sense to use cmake for this?
> If I don't select 'shell' in cmake, it won't be installed.
>

All logic is in CMake, and all building etc is done with make. So with
CMake you decide what should be compiled etc, and then the proper make
targets are created. So in this case if the shell is enabled using CMake,
there will be a make install-shell target.


>
> Otherwise the user needs to specify the bundles in both cmake and make.
> Please correct me if I'm wrong.
>

I hope above statement is enough :).


>
> I don't currently have the latest version installed, but a few weeks ago
> this was the list of bundles that did not get installed, and IMHO should be:
>

This is exactly the reason why I do like to change this. Your opinion is
the list you supplied, someone else his opinion might be completely
different. Eg for a lot people a deployment admin and rsa isn't needed.

So instead of catering everyone's special needs I think one common solution
makes more sense. With my proposed changes the following flow will be done
by a user/developer:
* Run ccmake and select all parts you want to build and install then run
configure and generate
* Run make to build everything
* Run make install-bundles to install the bundles
* Run make install-framework to install the framework and dependencies
* Or run make install-all to install everything

Note: Everything in this sense means everything the user enabled in the
configuration.
Note: I left out a make deploy, because a user of Celix will have his own
deployment.

Hope this makes it a bit clearer!


-- 
Met vriendelijke groet,

Alexander Broekhuis

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message