celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ferry Huberts <maili...@hupie.com>
Subject Re: [RFC] [PATCH v1 0/9] More Fixes
Date Sat, 14 Jul 2012 07:54:42 GMT


On 14-07-12 09:09, Alexander Broekhuis wrote:
> Hi Ferry,
>
> Thanks for the patches! I'll look into it tomorrow or somewhere next week.
>
> Some things I notice:
>
> Eclipse path: normally eclipse should pick up the includes itself if
> compilation is done from within eclipse. I do have mixed result with this
> however, so I'll check if the mentioned includes are any problem.
>

it should but they were there in the include file

> Added linux/limits.h: Celix doesn't only target Linux as platform, as such
> I don't think those should be added. What are the errors/warnings resulting
> in this needed header? I think it is important to keep the code clean from

eclipse complains about stuff.

I asked for review because I could not find something like a __linux__ 
define

I work on olsr as well, and that codebase is very cross platform but 
there we have many parts that are OS specific. IMHO you can't avoid that 
in cross platform code...

> platform specific solutions (at least, all new code, I guess several older
> parts aren't that clean). But everything at least also compiles on OSX,
> which definitely doesn't have a linux/limits.h.
> If something is going wrong we'll have to check out a platform independent
> solution.
>
> The others I'll need to check out.

tnx

-- 
Ferry Huberts



Mime
View raw message