archiva-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olivier Lamy <ol...@apache.org>
Subject Re: small bug in create-missing-checksums consumer
Date Mon, 23 Mar 2015 03:33:43 GMT
so I had a bit of time and fixed that.
Thanks for reporting the issue!!

On 23 March 2015 at 10:49, Olivier Lamy <olamy@apache.org> wrote:

>
>
> On 19 March 2015 at 21:11, Isabelle Guimiot <isabelle.guimiot@gmail.com>
> wrote:
>
>> Hi,
>>
>> I noticed that checksum files were always created again on all the
>> artifacts during each repo scanning. In the log, I could see messages
>> like :
>>
>>  Created missing checksum file
>>
>> /archiva_install/repositories/internal/com/company/project/myjar/1.2/myjar-1.2.jarsha1
>>
>> There's a dot missing at the end of the path, should be myjar-1.2.jar.sha1
>> instead of myjar-1.2.jarsha1 , and I think this issue comes from this line
>> in the code, file ArtifactMissingChecksumsConsumer.java :
>>
>>  File checksumFile = new File( this.repositoryDir, path +
>> checksumAlgorithm[0].getExt() );
>>
>> It should be :
>>
>>  File checksumFile = new File( this.repositoryDir, path + "." +
>> checksumAlgorithm[0].getExt() );
>>
>> Because without the dot, it doesn't find the checksum file, wrongly thinks
>> it's missing, and re-creates it ! It's not a blocker bug, but it slows
>> down
>> large repos scanning...
>>
>
> Sounds definitely a bug :-)
>
>
>>
>> Need a jira for this ?
>>
>
> Yes please (just to have a reminder :-) )
>
>>
>> Thanks !
>>
>> Isabelle
>>
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>



-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message