ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] arturobernalg commented on a change in pull request #157: Performance:
Date Sun, 26 Sep 2021 07:20:04 GMT

arturobernalg commented on a change in pull request #157:
URL: https://github.com/apache/ant/pull/157#discussion_r716156789



##########
File path: src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java
##########
@@ -94,9 +94,8 @@ private int moveArgFileEligibleOptionsToEnd(String[] commandLine) {
         for(int i = nonArgFileOptionIdx + 1; i < commandLine.length; i++) {
             if (!isArgFileEligible(commandLine[i])) {
                 String option = commandLine[i];
-                for(int j = i - 1; j >= nonArgFileOptionIdx; j--) {
-                    commandLine[j + 1] = commandLine[j];
-                }
+                if (i - nonArgFileOptionIdx >= 0)

Review comment:
       HI @bodewig 
   I just add the braces.
   TY




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message